Fixed multiple artists in album not loading up #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmac
reviewed
May 1, 2022
| @@ -901,7 +901,9 @@ def albumToTracks(self, album, bId): | |||
| ): | |||
| songartists = artists | |||
| else: | |||
| songartists = [Artist(name=song["artists"])] | |||
| songartists = [] | |||
| for artist in song["artists"]: | |||
There was a problem hiding this comment.
Do we know if this is always a list here?
I was going to submit a pull request which checked if it's a list and falls back to the existing else, like this:
elif type(song["artists"]) is list:
# handle case where we have a list of dictionaries like:
# [{'name':..., 'id':...}, ]
songartists = [Artist(name=sa["name"])
for sa in song["artists"]]
else:
songartists = [Artist(name=song["artists"])]but I am new to using this project, so I'm not sure if we need the extra check or not.
Edit: fixed my code to add multiple Artist instances, like yours. Basically I'm just wondering if we need to check it it's a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue, #39